fix unescaped '"' in json writing

[ritchie46]

fixes #811.

This is a quick hack that also searches for " before branching.

However, the second branch first did an unnecessary heap convertion from &str -> String. I removed it and the tests still succeed.

I think that we maybe should not branch at all now we don' do this heap allocation? Because we are now doing a double scan over the data determine which path we must take.

[codecov]

Codecov Report

Merging #812 (010b714) into main (9a8edd0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   71.16%   71.15%   -0.01%     
==========================================
  Files         327      327              
  Lines       17515    17508       -7     
==========================================
- Hits        12464    12458       -6     
+ Misses       5051     5050       -1     

Impacted Files	Coverage Δ
src/io/json/write/serialize.rs	88.28% <100.00%> (+0.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8edd0...010b714. Read the comment docs.

[jorgecarleitao]

Thanks! I am working on a alloc free version, one sec :P

[jorgecarleitao]

Alternative: #813

[jorgecarleitao]

Actually, I think your proposal is better: do not branch and always use serde_json 👍

[ritchie46]

Haha.. just let me know which PR that will be. 🙈

[jorgecarleitao]

This one is way better. Thanks for the quick fix!