Basic support for rails 4.1 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def filtered_model_classes | ||
| (ActiveRecord::Base.descendants - model_classes_to_exclude).reject do |klass| | ||
| klass.name.start_with?('HABTM_') |
There was a problem hiding this comment.
The generated has_and_belongs_to_many classes start with this prefix, so I'm excluding them all here.
jorgemanrubia
added a commit
that referenced
this pull request
Oct 4, 2015
Basic support for rails 4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a few fixes to get forceps to mostly work with rails 4.1. I don't think its backwards compatible though.
I wasn't able to get has_and_belongs_to_many associations to work because they have completely changed in 4.1. They are now modeled as a has_many to a generated class. I'm excluding that generated class, so if you don't use that relationship, then forceps will work.