Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedi refactoring #1767

Merged
merged 6 commits into from
Nov 15, 2020
Merged

Jedi refactoring #1767

merged 6 commits into from
Nov 15, 2020

Conversation

galaunay
Copy link
Collaborator

@galaunay galaunay commented Mar 29, 2020

PR Summary

Follow #231.

Drop Rope and implement Jedi refactoring tools.

Things to do

  • Implement 'rename'
  • Implement 'inline'
  • Implement 'extract_variable'
  • Implement 'extract_function'
  • Replace old rope keybindings with new ones
  • Update the documentation
  • Warn users if they have jedi < 0.17.0
  • Switch to the new jedi API (for get_definitions, get_docstring, ...).

PR checklist

  • Commits respect our guidelines
  • Tests are passing properly
  • Tests has been added to cover the change (elisp)
  • Tests has been added to cover the change (python)
  • The documentation has been updated

@coveralls
Copy link

coveralls commented Sep 27, 2020

Coverage Status

Coverage increased (+3.04%) to 94.882% when pulling acc2ad3 on galaunay:jedi-refactoring into 74eb42c on jorgenschaefer:master.

@galaunay galaunay force-pushed the jedi-refactoring branch 3 times, most recently from f484274 to a90d579 Compare October 4, 2020 00:26
@galaunay galaunay force-pushed the jedi-refactoring branch 2 times, most recently from de90bc6 to 1b26fdf Compare November 15, 2020 17:09
@galaunay galaunay merged commit 7531378 into jorgenschaefer:master Nov 15, 2020
@galaunay galaunay deleted the jedi-refactoring branch November 15, 2020 17:25
@sten0
Copy link
Contributor

sten0 commented Dec 10, 2020

@galaunay, thank you for working on this. Two other related issues that this PR may have closed by now (or that this work will close) are #231 and #1449.

@doolio
Copy link

doolio commented Dec 27, 2020

If rope is no longer being used by elpy do the other references to rope in the codebase need cleaning up?

@sten0
Copy link
Contributor

sten0 commented Dec 27, 2020

@doolio, if you have time to take a look at #1865 I would be very grateful. In particular, the PosixPath change in Jedi and Parso seems like it should be higher priority than a Rope cleanup.

@doolio
Copy link

doolio commented Dec 28, 2020

Sorry sten0, I'm not going to be much help here. I'm only a beginner self-taught programmer. Wish you luck in resolving your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants