Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Change `pretty' test regexp to pass tests on emacs 30. #239

Closed
wants to merge 1 commit into from

Conversation

nicolas-graves
Copy link

This is a regexp change that should match test native compilation on both emacs 29 and emacs 30. Should fix #238.

@mekeor
Copy link

mekeor commented Oct 3, 2023

As discussed in Guix' bug tracker, this PR does not fix the problem: http://issues.guix.gnu.org/66298

@mekeor
Copy link

mekeor commented Oct 3, 2023

Looking at the code of this PR, and my previous comment in the buttercup-bug-report, it's obvious that the new regular expression

(seq
 "λ (bc-bt-foo \""

won't match

λ (bc-bt-foo

because of the trailing whitespace. Instead, it should begin like this, I guess:

(seq
 "λ (bc-bt-foo"

@snogge
Copy link
Collaborator

snogge commented Oct 18, 2023

I did not notice this PR or #238 before fixing the issue in dfef8cf.

@snogge snogge closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New failures with native-compilation on emacs-next-minimal-30.0.50-1.9d27b95
3 participants