Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.6 support #10

Merged
merged 2 commits into from Apr 15, 2016
Merged

Conversation

jgrund
Copy link
Contributor

@jgrund jgrund commented Apr 14, 2016

Python 2.6 support

We have a project that uses Python 2.6 and would like
to use this tool to verify our commit messages.

This PR imports OrderedDict from the ordereddict
package if the built-in from collections is not present.

We have a project that uses Python 2.6 and would like
to use this tool to verify our commit messages.

This PR imports OrderedDict from the ordereddict
package if the built-in from collections is not present.

Signed-off-by: Joe Grund <grundjoseph@gmail.com>
@jorisroovers
Copy link
Owner

Thanks for the PR :-)

It's interesting that you've uncovered a bug in gitlint in that it complains about merge commit titles exceeding the default min length of 72 chars. See here: https://travis-ci.org/jorisroovers/gitlint/jobs/123068718. I've created #11 for that and will fix this by adding an option for gitlint to ignore title length on merge commit.

Regarding your PR, can you also modify install_requires in setup.py to include the ordereddict dependency? That way your code will still work when installed from pypi.

I'll look into "officially" supporting 2.6 (i.e. enabling unit tests for 2.6 in travis) once your PR is merged :-)

@jorisroovers jorisroovers merged commit 2a2b851 into jorisroovers:master Apr 15, 2016
jorisroovers pushed a commit that referenced this pull request Apr 15, 2016
We have a project that uses Python 2.6 and would like
to use this tool to verify our commit messages.

This PR imports OrderedDict from the ordereddict
package if the built-in from collections is not present.

Signed-off-by: Joe Grund <grundjoseph@gmail.com>
@jgrund jgrund deleted the python2-6-support branch April 15, 2016 15:04
@jgrund
Copy link
Contributor Author

jgrund commented Apr 15, 2016

Thanks! When do you expect the next version to be published?

@jorisroovers
Copy link
Owner

Hopefully somewhere next week. Still a few other things I want to get in.

@jorisroovers
Copy link
Owner

Released! Thanks again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants