-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed-functions breaks mathjs for iOS 9.3 #1062
Comments
I think the 'name' property of a function is configurable (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/name) and so we can delete it first and then reassign it a value to work around this. I don't think this will work on older browsers though. Is the name of a function used apart from as a debugging tool? If not then this entire line could be surrounded by a try-catch so that |
Thanks for reporting this issue! It should be easy to make a fallback for older browsers and browser that don't allow replacing a function name, will look into it within a few days. |
I am also seeing this on older android versions. Threw me for a loop cause didn't have a clue where the error was coming and it's just including the mathjs@4.0.0 release. |
setting the `name` property of a function (see josdejong/mathjs#1062)
This should be fixed now in v4.0.1 |
Thanks a lot ! |
https://github.com/josdejong/typed-function/blob/master/typed-function.js#L1096
This throws
TypeError: Attempting to change value of a readonly property.
thus preventing mathjs to load.Tested with iOS 9.3 (can be reproduced with desktop safari 9.1).
The text was updated successfully, but these errors were encountered: