Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Diff function #1920

Merged
merged 19 commits into from Jul 19, 2020
Merged

Updated Diff function #1920

merged 19 commits into from Jul 19, 2020

Conversation

Veeloxfire
Copy link
Contributor

@Veeloxfire Veeloxfire commented Jul 17, 2020

I believe this covers everything mentioned in #1812

I've also made it so that arrays containing matrices work as if they were just arrays. This means that you can now do the difference between a matrix and an array which I think would have thrown an error before.

I've made it so that bignumbers can be used as indexes but I think someone should look at that and check that I havent made any errors as I've never used them before

Veeloxfire and others added 19 commits Apr 6, 2020
Shouldnt provide any issues for other systems I hope
Added tests and then fixed all linting issues
Tests for bignumber, fraction and units.
Added Unit tests for the 4 Errors. Also changed some small things
Matrices are all treated as arrays (of arrays) now. This was to prep for writing better docs
Currently it does say that it will be one-based in the parser but I havent done that yet
Also added bignumbers as indexes as that could be useful
@Veeloxfire Veeloxfire mentioned this pull request Jul 17, 2020
@josdejong
Copy link
Owner

@josdejong josdejong commented Jul 19, 2020

All works like a charm, also the transform. And all is very well tested @Veeloxfire 👍 . Thanks a lot.

@josdejong josdejong merged commit 84f2746 into josdejong:develop Jul 19, 2020
4 checks passed
@josdejong
Copy link
Owner

@josdejong josdejong commented Jul 19, 2020

For some reason some of the unit tests where failing on IE 11 (I think not directly related to diff itself). This commit fixes those: 80fb20f.

@josdejong
Copy link
Owner

@josdejong josdejong commented Aug 24, 2020

The new function diff is now available in v7.2.0. Sorry for the delays in the release, there was a holiday in between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants