gammaln #320
Closed
gammaln #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Nick, looks good so far! |
|
@nfoti I see that you've added some more commits after your initial PR. Is your PR ready to merge? |
Merged
|
Closing in favor of #2417. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the Lanzcos method to compute the logarithm of the gamma function since
log(gamma(x))can result in numerical problems.The current commit is not complete in that the tests should be expanded, the documentation needs to be thorough, and there may be some other types that
gammalnshould handle. However, I wanted to submit this to start getting feedback.Thanks.