Skip to content

Commit

Permalink
Merge pull request PHPMailer#503 from fbonzon/patch-1
Browse files Browse the repository at this point in the history
Fix comments about $Hostname
  • Loading branch information
Synchro committed Sep 19, 2015
2 parents b192b45 + 4cd1309 commit d9b8d4a
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions class.phpmailer.php
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,16 @@ class PHPMailer
public $ConfirmReadingTo = '';

/**
* The hostname to use in Message-Id and Received headers
* and as default HELO string.
* If empty, the value returned
* by SERVER_NAME is used or 'localhost.localdomain'.
* The hostname to use in the Message-ID header and as default HELO string.
* If empty, PHPMailer attempts to find one with, in order,
* $_SERVER['SERVER_NAME'], gethostname(), php_uname('n'), or the value
* 'localhost.localdomain'.
* @type string
*/
public $Hostname = '';

/**
* An ID to be used in the Message-Id header.
* An ID to be used in the Message-ID header.
* If empty, a unique id will be generated.
* @type string
*/
Expand Down Expand Up @@ -234,7 +234,8 @@ class PHPMailer

/**
* The SMTP HELO of the message.
* Default is $Hostname.
* Default is $Hostname. If $Hostname is empty, PHPMailer attempts to find
* one with the same method described above for $Hostname.
* @type string
* @see PHPMailer::$Hostname
*/
Expand Down Expand Up @@ -365,7 +366,7 @@ class PHPMailer
/**
* Whether to generate VERP addresses on send.
* Only applicable when sending via SMTP.
* @link http://en.wikipedia.org/wiki/Variable_envelope_return_path
* @link https://en.wikipedia.org/wiki/Variable_envelope_return_path
* @link http://www.postfix.org/VERP_README.html Postfix VERP info
* @type boolean
*/
Expand Down Expand Up @@ -1835,7 +1836,7 @@ public function createHeader()
if ($this->MessageID != '') {
$this->lastMessageID = $this->MessageID;
} else {
$this->lastMessageID = sprintf('<%s@%s>', $this->uniqueid, $this->ServerHostname());
$this->lastMessageID = sprintf('<%s@%s>', $this->uniqueid, $this->serverHostname());
}
$result .= $this->headerLine('Message-ID', $this->lastMessageID);
if (!is_null($this->Priority)) {
Expand Down

0 comments on commit d9b8d4a

Please sign in to comment.