Record update missing fields fix #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankBro
force-pushed
the
record-update-missing-fields-fix
branch
from
5c8ae52
to
706d8f5
Compare
FrankBro
force-pushed
the
record-update-missing-fields-fix
branch
from
706d8f5
to
976a3d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The record refinement update introduced this bug where it would try to typecheck missing fields even for record updates instead of simply type checking only the fields that are used. Confirmed test was broken before and pass now.
This is also specific to cases where the spec would be missing and the initial record would be compared to
any().