Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangesetForm: Only allow changeset as argument, removing auto mode #124

Merged
merged 12 commits into from
Dec 19, 2020
Merged

ChangesetForm: Only allow changeset as argument, removing auto mode #124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
acbb1b6
allow the changeset to be replaced
betocantu93 Dec 2, 2020
4aa4cfd
manual mode
betocantu93 Dec 3, 2020
e8f53c7
types and assert
betocantu93 Dec 3, 2020
a3d2a7f
separate context binding to a ToC component so we can let clients cre…
betocantu93 Dec 4, 2020
105edf7
update dummy
betocantu93 Dec 4, 2020
7e602fd
update tests
betocantu93 Dec 4, 2020
29ec610
lints
betocantu93 Dec 4, 2020
3bb803e
lints..
betocantu93 Dec 4, 2020
3e939a6
updates docs
betocantu93 Dec 6, 2020
9dfe74d
fix
betocantu93 Dec 6, 2020
2c794b9
comment update
betocantu93 Dec 6, 2020
ac5e5eb
finx lint
betocantu93 Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/changeset-form/addon/components/changeset-form/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<form
{{on "submit" this.handleSubmit}}
{{on "reset" this.handleReset}}
{{did-insert this.setup}}
josemarluedke marked this conversation as resolved.
Show resolved Hide resolved
{{did-update this.setup @changeset}}
{{did-update this.setup @model}}
...attributes
>
{{yield
Expand Down
7 changes: 3 additions & 4 deletions packages/changeset-form/addon/components/changeset-form/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@ interface ChangesetFormArgs {
}

export default class ChangesetForm extends Component<ChangesetFormArgs> {
changeset!: BufferedChangeset;
@tracked changeset!: BufferedChangeset;
josemarluedke marked this conversation as resolved.
Show resolved Hide resolved

@tracked hasSubmitted = false;

constructor(owner: unknown, args: ChangesetFormArgs) {
josemarluedke marked this conversation as resolved.
Show resolved Hide resolved
super(owner, args);

@action
setup() {
if (typeof this.args.changeset === 'undefined') {
assert(
'@model must be defined on <ChangesetForm> component if you do not provide a @changeset argument',
Expand Down