Fix off by one error and unhandled undefined in relay-listener #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there goseid 👋
Thank you for opening your first PR for the Tally Arbiter project!
We will review it soon!
TallyArbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.
|
Good catch! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to get relays configured properly and working on a fresh system I came across a state where ProcessTallyData was calling getRelayGroupById with a deviceId that didn't match any of the relay groups. The for loop in getRelayGroupById went through 5 of my 4 relay groups which resulted in comparing the deviceId property on an undefined item from the array and errored out.
After fixing the off by one, the getRelayGroupById function was returning undefined due to the deviceId not matching any groups and ProcessTallyData errored out when trying to compare property deviceId on undefined.