Improve Atem source #501
Merged
Improve Atem source #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrueger
approved these changes
Oct 29, 2022
| @@ -47,7 +47,7 @@ <h2> | |||
| </table> | |||
| </div> | |||
| <div class="alert alert-info mt-3" role="alert" *ngIf="getNetworkDiscoveryList().length > 0"> | |||
| Found {{ getNetworkDiscoveryList().length }} new sources in your network. | |||
| Found {{ getNetworkDiscoveryList().length }} new {{ getNetworkDiscoveryList().length === 1 ? 'source' : 'sources' }} in your network. | |||
There was a problem hiding this comment.
I recently read that it's bad practice to call functions in an angular template... however, as it was already there, we could probably leave it that way. I just thought I'd mention it since we're now calling that function at least twice as often.
| @@ -127,6 +130,9 @@ export class BlackmagicATEMSource extends TallyInput { | |||
| } | |||
|
|
|||
| private processATEMTally(): void { | |||
| const areSetsEqual = (a, b) => a.size === b.size && [...a].every(value => b.has(value)); //https://stackoverflow.com/a/44827922 | |||
| if(areSetsEqual(this.prvList, this.oldPrvList) && areSetsEqual(this.pgmList, this.oldPgmList)) return; | |||
There was a problem hiding this comment.
Is this only a problem with the atem source? Maybe it would make sense to do that one level "higher", meaning that TA filters duplicate tally data. Then, we would not have to check for that in each source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469