Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Atem source #501

Merged
merged 3 commits into from
Jun 17, 2023
Merged

Improve Atem source #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1270cf
Device discovery change messages
MatteoGheza Oct 27, 2022
36a011b
Prevent sending the same tally data in Atem source
MatteoGheza Oct 27, 2022
a2061ef
Update atem-connection library
MatteoGheza Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UI/src/app/_components/settings/settings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ <h2>
</table>
</div>
<div class="alert alert-info mt-3" role="alert" *ngIf="getNetworkDiscoveryList().length > 0">
Found {{ getNetworkDiscoveryList().length }} new sources in your network.
Found {{ getNetworkDiscoveryList().length }} new {{ getNetworkDiscoveryList().length === 1 ? 'source' : 'sources' }} in your network.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently read that it's bad practice to call functions in an angular template... however, as it was already there, we could probably leave it that way. I just thought I'd mention it since we're now calling that function at least twice as often.

<table class="table table-hover" *ngIf="getNetworkDiscoveryList().length > 0">
<thead>
<tr>
Expand Down
Loading