Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some UI Change on Tally View pages and chat components #523

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

chanx
Copy link
Contributor

@chanx chanx commented Dec 21, 2022

Tally View - Add Checkbox for Enable Chat/Disable Chat and automatically add ?chat=false as query params to url

Chat components can use device name instead of client only, so producer and other client can differentiate the chat is come from who.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there chanx 👋

Thank you for opening your first PR for the Tally Arbiter project!

We will review it soon!

TallyArbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.

Copy link
Collaborator

@hrueger hrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@josephdadams josephdadams merged commit 3c0cc50 into josephdadams:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants