Updates in workspace to solve errors and warnings #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated JS-DevTools/npm-publish@v1 to solve: Build CLI on Ubuntu The following actions uses node12 which is deprecated and will be forced to run on node16: JS-DevTools/npm-publish@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Changed to latest to handle: Build Docker image on Ubuntu The following actions uses node12 which is deprecated and will be forced to run on node16: crazy-max/ghaction-docker-meta@v2, docker/login-action@v1, docker/build-push-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Repository has been moved to docker org. Replace crazy-max/ghaction-docker-meta@v2 with docker/metadata-action@v5
To fix the errors: Analyze code (javascript) This version of the CodeQL Action was deprecated on January 18th, 2023, and is no longer updated or supported. For better performance, improved security, and new features, upgrade to v2. For more information, see https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/
To fix: Analyze code (javascript) The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, github/codeql-action/init@v1, actions/setup-node@v1, github/codeql-action/analyze@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Removed linux/ppc64le from build "Build Docker image on Ubuntu" in an attempt to make docker builds successfull. It previously failed with: josephdadams#38 [linux/arm64 5/5] RUN apk add --update nodejs npm && apk add --no-cache --virtual .build-deps alpine-sdk python3 && npm install node-gyp -g && npm i --ignore-script --omit=dev && npm uninstall bcrypt && npm install bcrypt && npm uninstall node-gyp -g && apk del .build-deps josephdadams#38 209.3 josephdadams#38 209.3 added 341 packages, and audited 342 packages in 2m josephdadams#38 209.3 josephdadams#38 209.3 30 packages are looking for funding josephdadams#38 209.3 run `npm fund` for details josephdadams#38 209.4 josephdadams#38 209.4 1 high severity vulnerability josephdadams#38 209.4 josephdadams#38 209.4 To address all issues, run: josephdadams#38 209.4 npm audit fix josephdadams#38 209.4 josephdadams#38 209.4 Run `npm audit` for details. josephdadams#38 ...
Updated missed actions/checkout@v2 to actions/checkout@v4 actions/setup-node@v1 to actions/setup-node@v4 The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates in workspaces for Build and CodeQL code scanning.
build.yaml
Build CLI on Ubuntu
JS-DevTools/npm-publish@v1 changed to JS-DevTools/npm-publish@v3
to solve:
The following actions uses node12 which is deprecated and will be forced to run on node16: JS-DevTools/npm-publish@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build Docker image on Ubuntu
crazy-max/ghaction-docker-meta@v2 changed to crazy-max/ghaction-docker-meta@v3
docker/login-action@v1 changed to docker/login-action@v3
docker/build-push-action@v2 changed to docker/build-push-action@v5
docker/build-push-action@v2 changed to docker/build-push-action@v5
to solve:
crazy-max/ghaction-docker-meta@v3 changed to docker/metadata-action@v5
to solve:
Removed platform linux/ppc64le from "Build Docker image on Ubuntu" in an attempt to make docker builds successfull.
It previously failed with:
With this removal we hope that the docker image once again will be built so that a new docker release can be built with code fixes that hopefully solves issue #603.
codeql-analysis.yml
github/codeql-action/init@v1 changed togithub/codeql-action/init@v2
github/codeql-action/analyze@v1 changed to github/codeql-action/analyze@v2
github/codeql-action/upload-sarif@v1 changed to github/codeql-action/upload-sarif@v2
actions/checkout@v2 changed to actions/checkout@v4
actions/setup-node@v1 changed to actions/setup-node@v4
to solve:
Not solved
What remains to solved is that the usage of samuelmeuli/action-electron-builder@v1.6.0 forces usage of node12. This will not be part of this PR.