IsotropicCovarianceModel throw if inputDimension=0

josephmure · Jun 6, 2024 · 5f62d30 · 5f62d30
1 parent af13c83
commit 5f62d30
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/lib/src/Base/Stat/IsotropicCovarianceModel.cxx b/lib/src/Base/Stat/IsotropicCovarianceModel.cxx
@@ -37,6 +37,8 @@ IsotropicCovarianceModel::IsotropicCovarianceModel(const CovarianceModel & oneDi
     const UnsignedInteger inputDimension)
   : CovarianceModelImplementation(inputDimension)
 {
+  if (!inputDimension)
+    throw InvalidArgumentException(HERE) << "In IsotropicCovarianceModel, the supplied inputDimension must be nonzero.";
   setKernel(oneDimensional);
 }
 

diff --git a/lib/test/t_KrigingAlgorithm_isotropic_std.cxx b/lib/test/t_KrigingAlgorithm_isotropic_std.cxx
@@ -83,6 +83,16 @@ int main(int, char *[])
       assert_almost_equal(krigingFittedCovarianceModel.getAmplitude()[0], 6.65231, 0.0, 1e-4);
     }
 
+    try
+    {
+      IsotropicCovarianceModel(SquaredExponential(), 0);
+      throw InvalidDimensionException(HERE) << "Invalid IsotropicCovarianceModel should have thrown";
+    }
+    catch(const InvalidArgumentException &)
+    {
+      // nothing to do
+    }
+
   }
   catch (TestFailed & ex)
   {

diff --git a/python/test/t_KrigingAlgorithm_isotropic_std.py b/python/test/t_KrigingAlgorithm_isotropic_std.py
@@ -40,3 +40,9 @@ def fitKriging(covarianceModel):
 ott.assert_almost_equal(
     krigingFittedCovarianceModel.getAmplitude()[0], 6.65231, 0.0, 1e-4
 )
+
+try:
+    ot.IsotropicCovarianceModel(ot.SquaredExponential(), 0)
+    raise ValueError("Invalid IsotropicCovarianceModel should have thrown")
+except TypeError:
+    pass