Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows newline/backslashes BadRequest fix #13

Conversation

stephen-moyer
Copy link

Resolves #12

StringBuilder on windows uses '\r\n' for new lines, which Loki doesn't like.
Loki also doesn't like backslashes '\', so I flip them to forward slashes.

@stephen-moyer stephen-moyer changed the title Sm/newline windows badrequest fix Windows newline/backslashes BadRequest fix Jun 11, 2020
@josephwoodward
Copy link
Owner

@steveadoo32 Great, thanks for fixing this!

@josephwoodward josephwoodward merged commit 2997661 into josephwoodward:master Jun 11, 2020
bradacina pushed a commit to bradacina/Serilog-Sinks-Loki that referenced this pull request Jul 8, 2020
…ows-badrequest-fix

Windows newline/backslashes BadRequest fix
@atomaras
Copy link

atomaras commented Sep 2, 2020

Thank you for fixing this! We have been having the same problem. Most of our logs were lost because of this. When can we expect a new nuget release with those fixes?

@josephwoodward
Copy link
Owner

This has now been release as part of the 2.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAD REQUEST(400) - error parsing labels: parse error at line {0}, col {1}: invalid char escape
3 participants