Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use define instead of #![deny(warning)] #1290

Conversation

christian-schilling
Copy link
Member

Setting #![deny(warnings) in the source can cause josh fail to build on different versions of rustc.
This way we only ensure there are no warnings on our "officially supported" rustc version, but allow building on other versions as well.

Change: warnings

@christian-schilling christian-schilling force-pushed the @changes/master/christian.schilling.de@gmail.com/warnings branch from a473b2b to 4b39a3c Compare October 26, 2023 10:22
@christian-schilling christian-schilling force-pushed the @changes/master/christian.schilling.de@gmail.com/warnings branch from 4b39a3c to a6216f0 Compare October 26, 2023 10:52
Setting #![deny(warnings) in the source can cause josh
fail to build on different versions of rustc.
This way we only ensure there are no warnings on our
"officially supported" rustc version, but allow building
on other versions as well.

Change: warnings
@christian-schilling christian-schilling force-pushed the @changes/master/christian.schilling.de@gmail.com/warnings branch from a6216f0 to 65946b2 Compare November 4, 2023 12:33
@christian-schilling christian-schilling merged commit 7b8259b into master Nov 4, 2023
1 check passed
@christian-schilling christian-schilling deleted the @changes/master/christian.schilling.de@gmail.com/warnings branch November 4, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant