Report invalid action response as an assertion failure

joshgaber · Oct 11, 2020 · 1437b1a · 1437b1a
1 parent 83c63ee
commit 1437b1a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/Actions/MockActionResponse.php b/src/Actions/MockActionResponse.php
@@ -4,12 +4,13 @@
 
 use JoshGaber\NovaUnit\Constraints\IsActionResponseType;
 use PHPUnit\Framework\Assert as PHPUnit;
+use PHPUnit\Framework\Constraint\IsType;
 
 class MockActionResponse
 {
     private $response;
 
-    public function __construct($response)
+    public function __construct($response = null)
     {
         $this->response = $response;
     }
@@ -25,7 +26,10 @@ public function assertResponseType(string $type, string $message = ''): self
     {
         PHPUnit::assertThat(
             $this->response,
-            new IsActionResponseType($type),
+            PHPUnit::logicalAnd(
+                new IsType('array'),
+                new IsActionResponseType($type)
+            ),
             $message
         );
 

diff --git a/tests/Feature/Actions/MockActionResponseTest.php b/tests/Feature/Actions/MockActionResponseTest.php
@@ -138,4 +138,11 @@ public function testItFailsWhenThereIsNoDangerMessage()
         $mockActionResponse = new MockActionResponse(Action::message('Test Message'));
         $mockActionResponse->assertDangerContains('test');
     }
+
+    public function testItFailsOnNoResponse()
+    {
+        $this->shouldFail();
+        $mockActionResponse = new MockActionResponse();
+        $mockActionResponse->assertResponseType('message');
+    }
 }