-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Travis for testing, fixing minor PIP violations. #40
Conversation
👍 I had a few observations about the tests for the future:
If you want, I can apply the above ideas in the tests that I'll be adding for the _Method changes unless you'd prefer consistency with the other tests. Let me know. |
module without any parameters to run the tests. | ||
|
||
Currently, this is not easily tested with a framework like | ||
Currently, this is not easily tested with a framework like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is a little contradictory now that you are using nose.
You bring up several very good points -- to be honest, this project has remained mostly unchanged for years, and I wrote it pretty early in my Python learning. :) It needs a fairly thorough overhaul to be brought up to a decent standard. Your notes highlight some of that. I've made a couple of the changes (fixed the message, and moved to dynamic ports) you recommended, if you'd like to make some tweaks yourself I certainly would appreciate it! That being said, your change is currently blocked by this PR, and this PR would help move the project into a healthier process (if not fixing some of the issues themselves). Whenever we feel like this is "good enough" to move to next step, we should probably do that and then tackle next cleanup items. Thoughts? |
@joshmarshall I fully agree this is good enough. My notes were just ideas for the future. I added a comment in the source regarding the port stuff. I'm still 👍 on this PR with or without any further changes. |
Adding Travis for testing, fixing minor PIP violations.
In order to support other people actually contributing sanely, I've added the first step of Travis integration so it runs the (minimal) existing tests in both 2.6 and 2.7. As I went through I made minor whitespace corrections and any test changes necessary to run with nosetests in both unittest and unittest2 test cases.
Feedback desired!