Make the scope of in place import more explicit (edits) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--transfer=cp is copy but also in-place.
joshmoore
reviewed
Jun 11, 2019
| @@ -4,7 +4,7 @@ In-place import | |||
| =============== | |||
|
|
|||
| In-place import allows files which are already present on the server machine | |||
| to be imported into OMERO without the need to copy them into OMERO's ManagedRepository. This requires | |||
There was a problem hiding this comment.
This might be a question for @fmeyenhofer. He added this specifically trying to get something across.
fmeyenhofer
reviewed
Jun 11, 2019
|
|
||
| Do not use soft links when pointing to data inside the | ||
| ManagedRepository. If the originals are deleted, the data will be | ||
| lost. |
There was a problem hiding this comment.
This is the piece of information was missing for me. Good idea to add it.
fmeyenhofer
reviewed
Jun 11, 2019
| @@ -4,7 +4,7 @@ In-place import | |||
| =============== | |||
|
|
|||
| In-place import allows files which are already present on the server machine | |||
There was a problem hiding this comment.
Rephrasing: In-place import allows image files that are accessible from the OMERO.server's filesystem...
(because they do not have to be stored on the server machine, but can be on any machine if mounted into the servers FS)
|
Merging to update the commit. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of thoughts for you to cherry-pick or merge as you like.