Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some issues when using custom sampler #401

Closed

Conversation

ColmTalbot
Copy link
Contributor

I ran into some issues trying to use a customised Sampler subclass and with a different proposal distribution.

The changes in this PR allow me to fairly simple define the new class and function to modify the analysis.

@ColmTalbot
Copy link
Contributor Author

Ping @joshspeagle @segasai

@segasai
Copy link
Collaborator

segasai commented Oct 5, 2022

Thanks for adding a new test. that was previously lacking, because I never used this functionality
One quick comment is that I think it would be better to make the test not part of test_egg because here IMO we don't particularly care about the complex function to sample, we just care that the code can run (i.e. a single gaussian like in test_gau would do).. Also I'm not sure the test needs to be part of the itertools.product over bounds too (i.e. custom+rslice and multi+sample_rwalk combinations would do).
The reason for these comments is that the test execution time is a concern, so one should try to make tests as short as possible.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3191988185

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 91.472%

Totals Coverage Status
Change from base Build 3185506400: 0.1%
Covered Lines: 3990
Relevant Lines: 4362

💛 - Coveralls

@segasai
Copy link
Collaborator

segasai commented Oct 9, 2022

thank for the PR.
I've merged the edited version of it in #402

@segasai segasai closed this Oct 9, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants