Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ahkpm include generates #Include directives that are not compatible with AHK2 #180

Closed
joshuacc opened this issue Nov 27, 2022 · 1 comment · Fixed by #183
Closed

ahkpm include generates #Include directives that are not compatible with AHK2 #180

joshuacc opened this issue Nov 27, 2022 · 1 comment · Fixed by #183
Labels
bug Something isn't working
Milestone

Comments

@joshuacc
Copy link
Owner

This was originally reported by @anonymous1184 in #176.

Quoted below:


Now, what about AHK v2? It was in alpha for like 10 years and in the past 3 quarters went from alpha to 15 betas to RC. Given that your project is written in Go, you can add compatibility regardless of what the users have installed. And is just the removal of the comma:

#Include, %A_ScriptDir%\ahkpm-modules.ahk
;       ^------ v1 compatible only

#Include %A_ScriptDir%\ahkpm-modules.ahk
;       ^------ v1/v2 compatible

; Optionally
#Include %A_ScriptDir%\ahkpm-modules
@joshuacc joshuacc added the bug Something isn't working label Nov 27, 2022
@joshuacc joshuacc added this to the 0.7.0 milestone Nov 28, 2022
joshuacc added a commit that referenced this issue Nov 28, 2022
joshuacc added a commit that referenced this issue Nov 28, 2022
@hwayne
Copy link

hwayne commented Apr 12, 2023

AND NOW ITS REAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants