-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export language feature not working #35
Comments
Thanks for bringing this to my attention; this was working correctly, but I confirm you are correct and this is currently not working. Looks like LinkedIn changed the way their API works; it used to behave so that a GET request that did not have a specific language requested would always return with Note to self: This should be easy to fix, I can probably just initialize In the meantime (before I patch and push an update), you should be able to work around this by:
Toggling back and forth in the popup sets the language string, and doing so should force it to explicitly request |
Hey, thanks for the attention. I tried toggling the language setting back and forth in the popup 2 times, as you suggested, but it didn't work. I then tried 4 times back and forth and still no luck. Also, I don't know hoe relevant this is, but it didn't have a difference with Run or Save buttons. Let me know when you have found the fix! |
@dlucenad Hello again. Apologies for my delay in getting started on this. I just sat down to code the fix for this, and it looks like LinkedIn might have actually reverted the change they made to their API between when I last investigated and now. When you have a moment, could you please check if this is still affecting your profile? If so, I might have to add some extra debugging to the extension so that I can track down what is specifically happening with your browser. |
Hi @joshuatz, no worries! Unfortunately this is still not working for my profile. No matter which version of JSONResume I'm using and even if I toggle the language setting back and forth I always get the data in Let me know how else I can help you. |
I think I finally found the issue. It looks like LinkedIn is in the process of changing how multi-lingual profile data is returned; instead of being separated by request, multiple languages are bundled together and the separate locales are nested layers deep in each response. Even stranger is that this behavior seems to be enabled only for when the creator of a multi-lingual profile is looking at their own profile. This explains why you kept seeing the bug while I could not (in order to track this down, I ended up using a profile that has multiple languages turned on and then tried to extract my own profile). Unfortunately, this makes this a much harder fix; pretty much every subsection parser (work, education, etc.) is going to have to be updated. Rather than changing one header string, I have to recurse through every response from LI, checking for I have a bit of a backlog of tasks at that moment, but hopefully this week I can take a crack at this (now that I have a plan of attack) and have another update for you soon. In the meantime, if you urgently need an export of your own profile in |
Thanks for the in depth feedback and your plan of attack looks promising! I'm not in a rush to get my profile in English. To be honest I already created a JSONResume in English using the extract from your extension (which for me is only in Portuguese) and translating every sentence by myself. It will be nice to have this working for my type of profile since my LinkedIn is usually my most updated resume and it will save time to update my JSONResume in the future. Let me know when you need me to test the new version for you. |
- This is working towards fix for #35, since Dash endpoint seems to be only way to get multi-lang export for your own profile - Still need to integrate with parseViaInternalApiFullProfile and all other applicable methods
- Tie together alternate Dash endpoint with existing methods - Patch extractors that have to be adapted for Dash variation of data - Update popup to *always* pass currently selected locale
@dlucenad I believe I have finally patched this issue - released now as You can sideload the zip from the release page, or simply wait until Chrome Webstore accepts my update and pushes it out (usually within 24 hours). Once you have the newest version, please give it a test and let me know if the issue still persists for you. |
Yes, sir! Now it's working fine with both languages from my profile. |
Hi, my LinkedIn profile has the option of language selection so the viewer can easily change it according to their preference: Portuguese or English. Unfortunately, I can only export my data to JSON in Portuguese, which is my primary profile language. I've tried switching the display language on LinkedIn and also in the drop down menu in the extension but neither of the options work. Any idea of a workaround?
The text was updated successfully, but these errors were encountered: