Bugfix: Exporting your own multi-lingual profile, overriding defaultLocale #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is working towards fix for #35, since Dash endpoint seems to be only way to get multi-lang export for your own profile - Still need to integrate with parseViaInternalApiFullProfile and all other applicable methods
- Tie together alternate Dash endpoint with existing methods - Patch extractors that have to be adapted for Dash variation of data - Update popup to *always* pass currently selected locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #35
This ended up being a fairly complicated fix, because I could find no workable way to make the existing profile endpoint return data for a language other than the viewer's default locale (when looking at your own profile). So I had to reconfigure the various extractors and parsers to handle a new endpoint.
This endpoint also nests multi-lingual data, instead of just returning it separately, so I also had to write a utility to recurse through and grab the correct nested data based on the locale that is currently desired for export.
For full details, check the updated docs (which discusses the quirks of LI's multi-lingual system) and the commits on this PR. I'll push a new release after I do some extra cleanup (unrelated to this PR).