Closes #9 -- fix inoperative check on type of 'unit' argument

joshuaulrich · Oct 24, 2018 · b779328 · b779328
1 parent 5dd4a25
commit b779328
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/R/microbenchmark.R b/R/microbenchmark.R
@@ -128,7 +128,7 @@ microbenchmark <- function(..., list=NULL,
                            setup=NULL) {
   stopifnot(times == as.integer(times))
   if (!missing(unit))
-    stopifnot(is.character("unit"), length(unit) == 1L)
+    stopifnot(is.character(unit), length(unit) == 1L)
 
   control[["warmup"]] <- coalesce(control[["warmup"]], 2^18L)
   control[["order"]] <- coalesce(control[["order"]], "random")

diff --git a/inst/tests/test_regression.R b/inst/tests/test_regression.R
@@ -16,6 +16,13 @@ test_unit_f <- function()
 }
 test_unit_f()
 
+test_unit_int <- function()
+{
+  out <- try(print(microbenchmark(NULL, unit=4)), silent = TRUE)
+  stopifnot(!inherits(out, "try-error"))
+}
+test_unit_int()
+
 test_simple_timing <- function()
 {
   set.seed(21)