Skip to content

simplified signature and implementation#344

Merged
joshuaulrich merged 2 commits into
joshuaulrich:masterfrom
ethanbsmith:343_remove_data_type_parameter
Oct 16, 2021
Merged

simplified signature and implementation#344
joshuaulrich merged 2 commits into
joshuaulrich:masterfrom
ethanbsmith:343_remove_data_type_parameter

Conversation

@ethanbsmith

Copy link
Copy Markdown
Contributor

simplified function signature and implementation to better support subsequent maintenance
should not be breaking change as existing usage of data.type is handled by ...

closes #343

@ethanbsmith

Copy link
Copy Markdown
Contributor Author

just realized that the the whole section below can be further simplified to probably 1 line. Ill do some testing and add another commit

 h <- curl::new_handle()
    curl::handle_setheaders(h, Authorization = paste("Token", api.key))
    response <- curl::curl_fetch_memory(URL, h)
    response.data <- rawToChar(response$content)
    stock.data <- read.csv(text=response.data, as.is=TRUE, header=TRUE)

@joshuaulrich

Copy link
Copy Markdown
Owner

Close call... I was just about to merge! Let me know when you think this is ready.

further simplified call to read.csv
@ethanbsmith

Copy link
Copy Markdown
Contributor Author

should be gtg

@joshuaulrich
joshuaulrich merged commit f133a69 into joshuaulrich:master Oct 16, 2021
@joshuaulrich

Copy link
Copy Markdown
Owner

Awesome, thanks!

@ethanbsmith
ethanbsmith deleted the 343_remove_data_type_parameter branch March 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simplify getSymbols.tiingo

2 participants