Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify getSymbols.tiingo #343

Closed
ethanbsmith opened this issue Oct 15, 2021 · 1 comment · Fixed by #344
Closed

simplify getSymbols.tiingo #343

ethanbsmith opened this issue Oct 15, 2021 · 1 comment · Fixed by #344
Assignees
@ethanbsmith
Milestone
Release 0.4.20

Comments

@ethanbsmith
Copy link
Contributor

ethanbsmith commented Oct 15, 2021 •
edited
Loading

getSymbols.tiingo function signature and implementation expose details of the tiingo API that are not needed. specifically:

the data.type parameter affects the protocol between tiingo and quantmod. Since the quantmod implementation always converts the data to an xts, the caller is not affected by data is transferred over the wire and it just adds complexity. one path should be selected and this should be hard coded as an implementation detail. @tiingo has stated that the csv implementation is very slightly more efficient, so that would get my vote
@ethanbsmith ethanbsmith changed the title simplify getSymbol.tiingo simplify getSymbols.tiingo Oct 15, 2021
@ethanbsmith ethanbsmith mentioned this issue Oct 15, 2021
Merged
@ethanbsmith
Copy link
Contributor Author

this will simplify working on #289

joshuaulrich pushed a commit that referenced this issue Oct 16, 2021
@ethanbsmith
Simplify getSymbols.tiingo() implementation
f133a69 
Remove the data.type parameter because getSymbols.tiingo() always
converts to an xts object. This user is not affected by which protocol
is used and handling the JSON response adds complexity. Use the CSV
interface because Tiingo said it's slightly more efficient and it
simplifies our implementation.

Fixes #343.
joshuaulrich added a commit that referenced this issue Apr 29, 2022
@joshuaulrich
Remove data.type argument from docs
6803bbe 
See #343.
@joshuaulrich joshuaulrich added this to the Release 0.4.20 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanbsmith ethanbsmith

Labels
None yet
Projects
None yet
Milestone
Release 0.4.20
Development

Successfully merging a pull request may close this issue.

simplified signature and implementation ethanbsmith/quantmod
2 participants
@joshuaulrich @ethanbsmith