Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Clicking on GitHub link in dependencies doesn't work #48

Closed
skeithtan opened this issue Jul 15, 2018 · 2 comments
Closed

Clicking on GitHub link in dependencies doesn't work #48

skeithtan opened this issue Jul 15, 2018 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@skeithtan
Copy link

The link takes you to https://github.com/%5Bobject%20Object%5D instead of the actual page of the dependency.

I'm running the latest release version.
@joshwcomeau joshwcomeau added bug Something isn't working good first issue Good for newcomers labels Jul 15, 2018
@joshwcomeau
Copy link
Owner

Good find! Thanks for the report

@karlsander
Copy link
Collaborator

I think I see what causes the bug and am going to fix this issue, to get my feet wet setting the project set up locally.

joshwcomeau added a commit that referenced this issue Jul 16, 2018
@joshwcomeau
Merge pull request #58 from karlsander/fix#48-broken-github-link
11ecf94 
fix #48: get the repo url from package.json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karlsander @joshwcomeau @skeithtan