Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add warning when componentName is missing #3

Merged
merged 1 commit into from
Sep 3, 2017

Conversation

morajabi
Copy link
Collaborator

@morajabi morajabi commented Aug 29, 2017

Great project @joshwcomeau! it's my problem too, so I wanted to help with that. Well done!

fixes #1

@joshwcomeau joshwcomeau merged commit 12f1de4 into joshwcomeau:master Sep 3, 2017
@joshwcomeau
Copy link
Owner

yay :D Thanks @morajabi! Really appreciate your work on this.

@morajabi
Copy link
Collaborator Author

morajabi commented Sep 3, 2017

Wow, Thanks for adding me as a collaborator, Josh! I really appreciate it too. I hope I can add something worthy.

@joshwcomeau
Copy link
Owner

joshwcomeau commented Sep 3, 2017

@morajabi You beat me to it! I was just writing up some info about that :)

I've found that adding enthusiastic, competent community members as collaborators has been really awesome for the open-source projects I've been involved with. Your general enthusiasm for this project (discussing #2 and providing this PR) more than qualifies you!

Collaborators have full write access, so my only request is that you don't commit directly to master, and at least 1 other collaborator (for now, that's just me!) has reviewed code before it's merged in. But yeah, if I or any future collaborators open PRs, feel free to review/merge

Of course, accepting the invitation doesn't mean you have to do anything :) feel free to do as much or as little as you want. I'm about to open some issues for adding support for different styling solutions, and so your work with styled-media-query might mean you're interested in adding styled-components support? Will link to that issue when its open

@morajabi
Copy link
Collaborator Author

morajabi commented Sep 3, 2017

Thank you, Josh! You mentioned good points.

so my only request is that you don't commit directly to master, and at least 1 other collaborator (for now, that's just me!) has reviewed code before it's merged in.

I'm aware of that, so why don't you make it protected to avoid any unwanted damage?

Of course, accepting the invitation doesn't mean you have to do anything :) feel free to do as much or as little as you want.

I like your awesome work here (as I said on Twitter) and It makes me happy to contribute to something useful in the community that I love :)

I'm about to open some issues for adding support for different styling solutions, and so your work with styled-media-query might mean you're interested in adding styled-components support?

OK, no problem with that, actually now I'm a member of SC and I'm working on the main styled-component website too.

@joshwcomeau
Copy link
Owner

I'm aware of that, so why don't you make it protected to avoid any unwanted damage?

Huh, wasn't aware you could do such a thing! Thanks for the tip, just went digging through the settings and they're surprisingly powerful.

I'm a member of SC and I'm working on the main styled-component website too.

Congrats :D

@morajabi
Copy link
Collaborator Author

morajabi commented Sep 3, 2017

Congrats :D

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling new-component with no arguments creates 'undefined' component
2 participants