-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out navigation #83
Comments
Should we continue about nav and other stuff here or on the Spectrum? |
Let's continue here so everybody can chime in, this is better suited for the design discussion! |
How about the inner pages being dropdown when you click the main page ? |
I really like the top nav with conditional side nav option! I think that could work really well making the top nav the gradient background and then the side nav being a lighter gray to differentiate it from the main content. I think the logo could then be broken into the icon on the left and styled components text beside it. Then on mobile the text can be removed and only the icon is there. |
I quite like the two navigations! Two quick ideas:
|
I really like it as well :) two things however: I think the gradient is a bit off but don’t worry, since it’s already present in the code; second thing is the content container size. The one we have fits the content really well and the one in the design is too wide, so I’d probably preserve the current one. Apart from that this looks really awesome! Maybe I should try to work on a first version? I actually do have time today. That is, if no one else is more stoked and motivated than i am ;) |
Do it! I'm not sure I like the gradient at the top (too much imo, the one on the homepage is enough; I'm not a fan of our current sidebar one either) and the android-like treatment if the selected states but I think this would be a great prototype to get out 😊 |
What about my design on nav? It seems you’re going with this one. |
Wut! 😆 That's A1 branding right here @morajabi Can you post your design here so we can combine the two? I really like the dropdown behaviour of yours, while this one has a good alternative for the sidebar. |
I think I just have a larger screen! It was not my intention to redesign the content haha I think the plan with the main nav being more universal links is better! Was not aware of the expansion of the site! Also, I agree! part of the brand to me is the gradient now, but I think that it could just be the palevioletred as well and get the job done. 💯 |
@wking-io no worries! Just a note on my end regarding the sizing The gradient is actually a big question on my end here. I wasn’t aware that you’re more in favour of a more simple design, @mxstbr. Maybe we need some more feedback on some variations? It’d be simple to tweet out a plain flat-colour navigation bar vs the gradient one. I’m definitely in favour of only having the gradient on the navbar and not the sidebar. It makes it less attention grabbing. The gradient in general was an attempt to transition the branding from a brutalist approach to a minimalistic one. And overall people have reacted supportive of it, including @geelen. The navbar is certainly another question, but it does carry over some “fun” aspects and sets it apart from other sites. Happy to hear everyone’s thoughts on this 😬 |
Oh, btw, regarding the navbar + sidebar. I’d really love to reconcile this effort with @morajabi’s work. We’ll also need to think of the collapsed sidebar for mobile devices / smaller screens. In those cases it’s probably impossible to get around scrolling, but we have to design and think about it beforehand. For instance, a DropDown is good on desktop but horrible on touch devices, and scrolling will be necessary still on smaller screens and phones Edit: Including @morajabi's design to speed things up a little |
I think putting documentation headings in the sidebar makes more sense and it's easy to navigate. You should let the nav bar handle other things like what Babel, Webpack, Jest, React and others did and use a sidebar for content navigation. Anyway, it's my opinion :) I think what Redux did for navigation on mobile with a ||| (rotate 90deg) icon is great for mobile users. P.S: If have any opinions or you want to combine the best of two designs, I'd be happy to make a new design based what we need. |
What do you mean by scrolling? Where? |
@mxstbr I like this idea and it's more common in latest libs' docs. |
That navigation sidemenu might collapse on small screens. But since the screen is not only not wide enough, but also not long enough, you'll need to be able to scroll the content. So we might get rid of scrolling on desktop, but not on mobile. Which is ok! We just need to remember this. Btw; Here's instead of the screenshots a gif. @morajabi feel free to remove the images; I think this illustrates what we'd like a bit better :) |
Of course, GIF is better, Thanks for that :) @philpl What's your opinion on having Basic, Advanced and FAQ parts in the sidebar? (Read my earlier messages) |
It's works super well on the homepage, but it feels forced and weird on the navbar to me. The navbar is a utility, it shouldn't be the first thing you look at when you look at the page? I like where these designs are going, I can see the dropdowns in the nav working too! |
I think we should start to sum up what we expect from a nav, shouldn't we? |
Agreed! When you put it like that I think that @morajabi is right and we should outline the priority/hierarchy of the pages so we know where the focus is. Because it the above is true then I think we can really reduce the design and make the content on the pages themselves the focus. |
@philpl I will give it a hand if everyone is OK. Let me know. |
Yes please! |
@philpl What do you mean by this?
|
@mxstbr @philpl I've redesigned the parts and added some artboards and notes for each state. I copied the nav and changed the colour to see if it's what we like. (Don't forget to enable comment-mode from top left menu to see some comments). Also, the links I've put in the nav have no purpose and they're just placeholders as I didn't know which links are we going to put there. I'd appreciate your comments on that. And we can edit the parts which are not your preference. BTW, I think we need to redesign the Home page, too. With some extra elements (i.e tweets, who's using, use cases with image or GIF, etc). A richer page just like Jest, Flow, Babel and others. what do you think? |
@morajabi sorry, that was a bit unclear:
... of the "styled-components" wording on the left Edit: Just had a look and I think we should roll with it 🎉, although I'd like to see whether we can make due with the change above, even though it takes up more space. I don't necessarily want to perpetuate the "styled components" (no dash) name even more. Really amazing work on mobile! I think that should work perfectly
We have some other issues open for separate pages for tweets, etc. Right now the content is already a bit much and I think we need a visual space for the badges, but overall I think we should incrementally change it, and not change everything we can right now all at once. |
@philpl I'm glad you liked it!
I see, What font & styling should I use for the styled components? |
@morajabi So there's a couple of options here:
I actually realised that your design almost matches the logo but changed the You can find the resources here: https://github.com/styled-components/brand In case you don't have Sketch, I can export it in the format you need later today |
@philpl That was just a quick placeholder! I have Sketch actually but I used Figma because it has better collaboration support. |
What do you think now? @philpl |
@morajabi That looks perfect! Just have to make sure to export the wording of the logo as an image when we actually build this as we're not using Fira Sans anywhere else on the site :) |
@philpl That's OK but if we're going to import other fonts from Google, we can import just the letters s,t,y,l,e,d,c,o,m,p,n from Fira Sans like this: |
I love it, getting there for sure! |
Wow! I really appreciate that @mxstbr |
Since nobody has commented in the negative yet, let's implement this? 😊 |
Great! I'm busy now, Is it OK I start doing this tomorrow? |
Sounds great to me! |
One question, should I implement it on a branch of the current website? Is home page going to be like this? I think it's not going to match the navbar, so we should slightly redesign the first section of home page. |
Yeah, implement it on a branch and submit a PR!
I think we'll have to do some special treatment to the navbar on the homepage (no background?!) but let's figure that out once we have a first version (i.e. a WIP PR) and can quickly iterate? |
Should navbar be sticky? |
I don't think so, just because it takes away a lot of screen estate on mobile and doesn't really improve the experience, right? |
I think it should be sticky on mobile because it's the only handler to unfold the side nav. If it doesn't stick, you need to scroll all the way up to open side nav! |
Ah yeah, that's true. Good point let's make it sticky! |
Progress Report: Going for the mobile navbar view. |
@SaraVieira Can you take look? I'd be glad to know what you think, too! |
@morajabi I will do that tonight 🎉 |
Right now, even on a large screen, large portions of the nav are cut off:
That's not good, and it'll only get worse as we add more content to the site. We should figure out a better way of doing navigation.
We need a top nav for the "big pages" that should persist across all pages. (Homepage, Docs, Docs -> Basics, Docs -> Advanced, Docs -> FAQ, Docs -> Tooling, etc) We'll then likely still need some sort of side nav for the docs pages to navigate within them.
Any design/layout ideas and implementations welcome!
The text was updated successfully, but these errors were encountered: