-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a per-view custom alt tag #370
Conversation
Looks fab! Thanks for the PR (again)! |
No problem at all, thanks to you to helping maintain this! I spent all day (eh tbh like 20 minutes) looking at react lightboxes and it's clear this one is the best free one out there, so I'd be remiss to just use it without helping out. |
(Fwiw I can't merge so I'll just leave this for someone with commit rights to close) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see the console warn you're talking about. Could you point me to it?
Oops - forgot to hit "re-request review" - lemme know if there's anything else you'd like changed here @davwheat . |
Description of changes:
Adds support for a view to have an
alt
property that will be set as thealt
tag on the rendered image. This will override thecaption
if present and will not render anywhere else.This also adds a section to the README documenting the caption, alt, and source properties on ViewType.
Related issues (if any):
#369 - This is responding to confusion if using the HTML-as-caption feature without overriding the alt formatter.
Checks:
yarn run lint
ran successfully/src
and/examples/src
are committed