Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest update #21

Merged
merged 2 commits into from
Oct 12, 2021
Merged

manifest update #21

merged 2 commits into from
Oct 12, 2021

Conversation

tomer-regev
Copy link
Contributor

No description provided.

@tomer-regev
Copy link
Contributor Author

@josteink Please review

@josteink
Copy link
Owner

We’re this particular package-lock.json required or did you just check it in by default?

I’ve intentionally avoided adding it so far, to have less things to maintain 😅

@josteink
Copy link
Owner

The CI also seems unhappy about something on Node v15. Anything you can look into?

@josteink
Copy link
Owner

Looking at this issue here, it seems the build issue may in fact be directly related to your package-lock.json-file!

Try removing it and see if that fixes it?

@josteink
Copy link
Owner

I could actually reproduce that very same error locally:

image

And when removing the package-lock.json-file?

image

Tada! 😄

Not needed. Breaks build on Node >=15.
@josteink
Copy link
Owner

I've tested the bits I was most worried about too, and everything seems to work fine. Consider this merged!

And again: Thanks for the help!

@josteink josteink merged commit 8140089 into josteink:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants