Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osmjs before_ and after_ callbacks #61

Closed
ajashton opened this issue Jan 2, 2013 · 2 comments
Closed

osmjs before_ and after_ callbacks #61

ajashton opened this issue Jan 2, 2013 · 2 comments

Comments

@ajashton
Copy link

ajashton commented Jan 2, 2013

The init, end, node, way, & relation callbacks work fine, but none of the before_ or after_ callbacks do. I've created a js file to test all of the callbacks; when run (with various pbf and xml files) as described in the comment at the top the output is:

✔ init
✔ node
✔ way
✔ relation
✔ end

Apart from missing all of the before and after callbacks, the relations are handled later than I would expect based on the README and the -2 option being passed.

This is with latest master on Arch Linux.

@joto
Copy link
Owner

joto commented Jan 4, 2013

It seems those callbacks were never implemented. Fixed in c94a0eb.

Relation callbacks are called on the second pass. The documentation was wrong and has been fixed.

@joto joto closed this as completed Jan 4, 2013
@ajashton
Copy link
Author

ajashton commented Jan 4, 2013

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants