Merge nacli and netctl-auto #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function can be used to unquote WPA supplicant config file strings returned from wpa_cli calls.
This adds a command line interface to the netctl-auto script to allow users more control over the automatic profile selection.
|
|
||
| SEE ALSO | ||
| -------- | ||
| *netctl*(1), *netctl.profile*(5), *netctl.special*(7), *systemctl*(1) |
There was a problem hiding this comment.
why reference systemctl(1)?
|
Excellent! Only a few remarks. Contributions such as this one make me happy. |
|
|
||
| # List of enabled networks | ||
| local enabled_networks=$(wpa_call $interface list_networks | tail -n+2 | \ | ||
| cut -f 1,4 | fgrep -v '[DISABLED]' | cut -f 1 | tr "\n" ' ') |
There was a problem hiding this comment.
Use grep -F instead of fgrep.
|
Sorry for the delay, I'm currently on vacation and don't have easy internet access. But thanks for your feedback, I will fix the patch as soon as possible. |
|
I've pushed three commits which should fix the mentioned issues. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in gandro/netctl-auto-cli#1, this pull request contains a rewrite of the
netctl-autoscript, essentially adding a command line interface to control the automatic profile selection. The commands are the same as those ofnacli.In addition to the new commands, I've also documented the
startandstopcommands in the man page. As stated there, these commands are not supposed to be called by the user, but by systemd through thenetctl-auto@.serviceunit. Nonetheless I've reworked some ofnaclis code to work even ifnetctl-auto startwas invoked directly. Please let me know if should remove the commands from the documentation.