Add button to Zero scale #1
Conversation
.idea/.name
Outdated
| @@ -0,0 +1 @@ | |||
| journey-android-bluetooth-scale | |||
There was a problem hiding this comment.
The .idea folder (and any other IDE-generated files) should not be included in the git repo.
WesselWessels
force-pushed
the
feature/set-scale-zero
branch
from
235d014
to
bb5f2f1
Compare
WesselWessels
force-pushed
the
feature/set-scale-zero
branch
from
bb5f2f1
to
87f7c30
Compare
| @@ -100,6 +100,10 @@ public void disconnectScale(View view) { | |||
| } | |||
| } | |||
|
|
|||
| public void writeZero(View view) { | |||
There was a problem hiding this comment.
Why is a view parameter being passed in and not used?
There was a problem hiding this comment.
As far as I can tell, the onClick function requires the View parameter.
| @@ -85,6 +85,7 @@ public final synchronized void connectToDevice(BluetoothDevice bluetoothDevice) | |||
| setState(ConnectionState.CONNECTING); | |||
| } | |||
|
|
|||
|
|
|||
| @@ -14,6 +14,7 @@ | |||
| private final OutputStream outputStream; | |||
| private BluetoothService bluetoothService; | |||
| private final static int payloadSize = 11; | |||
| private final byte[] ZERO_INSTRUCTION_BYTES = new byte[]{0x02, 0x4B, 0x5A, 0x52, 0x40, (byte) 0xB7, 0x0D}; | |||
There was a problem hiding this comment.
Why is 0xB7 being cast to a byte?
This should be made static as well.
There was a problem hiding this comment.
I think it is because 0xB7 is negative. I casted all of them, just to be explicit and consequential.
There was a problem hiding this comment.
Ok. Found this mention about bytes being signed in Java: http://stackoverflow.com/a/13020962
| @@ -37,6 +38,15 @@ public BluetoothConnectedThread(BluetoothService bluetoothService, BluetoothSock | |||
| this.outputStream = outputStream; | |||
| } | |||
|
|
|||
| public void writeZero() { | |||
There was a problem hiding this comment.
It is not obvious what writeZero means. I suggest having a more descriptive name here, like sendZeroCommand for example (this applies to the other levels where this is called from as well).
| @@ -93,6 +93,11 @@ public final synchronized void connected(BluetoothSocket bluetoothSocket) { | |||
| setState(ConnectionState.CONNECTED); | |||
| } | |||
|
|
|||
| public void writeZero() { | |||
There was a problem hiding this comment.
This should also be sendZeroInstruction for consistency.
| @@ -14,6 +14,7 @@ | |||
| private final OutputStream outputStream; | |||
| private BluetoothService bluetoothService; | |||
| private final static int payloadSize = 11; | |||
| private final byte[] ZERO_INSTRUCTION_BYTES = new byte[]{0x02, 0x4B, 0x5A, 0x52, 0x40, (byte) 0xB7, 0x0D}; | |||
There was a problem hiding this comment.
Ok. Found this mention about bytes being signed in Java: http://stackoverflow.com/a/13020962
WesselWessels
force-pushed
the
feature/set-scale-zero
branch
from
5453f74
to
7440831
Compare
To zero the scale, the byte array
{0x02, 0x4B, 0x5A, 0x52, 0x40, (byte) 0xB7, 0x0D}is sent to the scale using the outputStream