Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time discrepancy #75

Closed
wills106 opened this issue Apr 8, 2024 · 8 comments · Fixed by #128
Closed

Time discrepancy #75

wills106 opened this issue Apr 8, 2024 · 8 comments · Fixed by #128

Comments

@wills106
Copy link

wills106 commented Apr 8, 2024

I have noticed a time discrepancy between the Workouts Sumary page and the timeline on the individual Workout page.

The "an hour ago" is correct. But the displayed time should be 16:18

image

Detailed Workout page
image

Timeline is correct
image

Just for info the Walk started 16:18 and current time as posting is 17:58

@wills106
Copy link
Author

wills106 commented Apr 8, 2024

The GPX does state 15:18, but I have selected London as time zone.
So it looks like the Timeline is using DST (GMT +1) but the other locations is just using GMT.

@jovandeginste
Copy link
Owner

Is it possible the timezone in your browser/on your system is not the same as the one you configured inside the web ui? The stats at the bottom are rendered in javascript, which uses the browser's timezone, while the ones in the summary and details are rendered server-side. I want to remove the dependency on javascript for this, however, but that's not ready yet.

@wills106
Copy link
Author

wills106 commented Apr 9, 2024

Does this help?

image

image

@jovandeginste
Copy link
Owner

You can check here: https://webbrowsertools.com/timezone/

@wills106
Copy link
Author

wills106 commented Apr 9, 2024

I used that for the second screenshot in the previous post.

@jovandeginste
Copy link
Owner

I used that for the second screenshot in the previous post.

🤦 sorry :)

@jovandeginste
Copy link
Owner

Anyway, it explains the discrepancy in times shown: the timeline uses the browser time, because it's client side...

@jovandeginste
Copy link
Owner

I have tried a number of solutions so far, without luck. I'm wondering if I should drop chartjs for a different library...

jovandeginste added a commit that referenced this issue Apr 18, 2024
We seem to have all features, and can add timezone awareness!

Fixes #75

Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
jovandeginste added a commit that referenced this issue Apr 18, 2024
We seem to have all features, and can add timezone awareness!

Fixes #75

Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
jovandeginste added a commit that referenced this issue Apr 18, 2024
We seem to have all features, and can add timezone awareness!

Fixes #75

Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
jovandeginste added a commit that referenced this issue Apr 18, 2024
We seem to have all features, and can add timezone awareness!

Fixes #75

Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants