Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jovo Model and other Platforms models merging strategy #250

Open
1 of 4 tasks
jrglg opened this issue Nov 4, 2021 · 1 comment
Open
1 of 4 tasks

Jovo Model and other Platforms models merging strategy #250

jrglg opened this issue Nov 4, 2021 · 1 comment
Assignees
Labels
Bug Google Conversational Actions Issues/PRs regarding Google Conversational Actions functionality. v4 Issues/PRs for v4 of the Jovo CLI

Comments

@jrglg
Copy link

jrglg commented Nov 4, 2021

I'm submitting a...

  • Bug
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

I cannot put FUZZY_MATCH in a custom Google Actions Type without overriding the full type.

platform.googleAssistant\custom\types\MyCustomType.yaml

synonym:
  entities:
    conversation:
      synonyms:
      - to have a conversation
    askSomething:
      synonyms:
      - to ask something
  matchType: FUZZY_MATCH

When I set Fuzzy Match from Google Actions Builder console and do a gactions pull, the above file is generated.
BUT when I override the type in Jovo Model, via GoogleAssistant object like this:

/model/en.json

"googleAssistant": {
    "custom": {
      "types": {
        "MyCustomType": {
          "synonym": {
            "matchType": "FUZZY_MATCH"
          }
        }
      },
...

The merging is failing because I get:
platform.googleAssistant\custom\types\MyCustomType.yaml

synonym:
  matchType: FUZZY_MATCH

Note that all the rest is gone. Merge operation not merging the Jovo Model part:
en.json

"entityTypes": {
    "MyCustomType": {
      "values": [
        {
          "value": "conversation",
          "synonyms": [
            "to have a conversation"
          ]
        },
        {
          "value": "askSomething",
          "synonyms": [
            "to ask something"
          ]
        }
      ]
    },
...

Instead, it's deleted from the generated type when build.

Your Environment

@jovotech/cli: 4.0.0-beta.9

@rubenaeg rubenaeg self-assigned this Nov 4, 2021
@rubenaeg rubenaeg transferred this issue from jovotech/jovo-framework Nov 4, 2021
@rubenaeg rubenaeg added Bug Google Conversational Actions Issues/PRs regarding Google Conversational Actions functionality. v4 Issues/PRs for v4 of the Jovo CLI labels Nov 4, 2021
@jrglg
Copy link
Author

jrglg commented Apr 1, 2022

This would be interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Google Conversational Actions Issues/PRs regarding Google Conversational Actions functionality. v4 Issues/PRs for v4 of the Jovo CLI
Projects
None yet
Development

No branches or pull requests

2 participants