Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ updated type #354

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

sadlowskij
Copy link
Contributor

Proposed changes

Type '{ name: PermissionName; }[]' is not assignable to type 'Files'.

When trying to build my AlexaCliConfig in a TS file, TS won't let me assign arrays to properties, where arrays are needed, like files['skill-package/skill.json'].manifes.permissions. It can still be used though and works, if you just ignore the issue (like mostly done in .js project files).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow requested a review from jankoenig April 24, 2023 11:20
@aswetlow aswetlow merged commit 91c50b8 into jovotech:v4/dev Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants