Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ updated alexa Plugin Config Files type #355

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

sadlowskij
Copy link
Contributor

Proposed changes

This is kind of an extra to this as that was not enough to make it work. Using the SkillManifest type of the ask-smapi-model package this should work now:

import { v1 } from 'ask-smapi-model/index';

//...

const alexaCliConfig: AlexaCliConfig = {
  skillId: this.config.skillId,
  askProfile: this.config.askProfile,
  locales: this.config.locales,

  files: {
    'skill-package/skill.json': {
      // buildManifest with return type DeepPartial<v1.skill.Manifest.SkillManifest>
      manifest: this.buildManifest(),
    },
  },
};

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@sadlowskij
Copy link
Contributor Author

Maybe instead of just allowing string would it make sense to just allow any primitve types? I'm not sure, why this is so restrictive here

@aswetlow aswetlow merged commit c7de41b into jovotech:v4/dev Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants