Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect SQLAlchemy primary key with custom column name #361

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Detect SQLAlchemy primary key with custom column name #361

merged 6 commits into from
Oct 28, 2023

Conversation

jowilf
Copy link
Owner

@jowilf jowilf commented Oct 28, 2023

close #347

@github-actions
Copy link

github-actions bot commented Oct 28, 2023 •
edited

🚀 Deployed on https://docs-preview-361--starlette-admin-docs-preview.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 28, 2023 03:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2023 03:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2023 03:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2023 04:02 Inactive
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24218b4) 100.00% compared to head (2b8329b) 100.00%.

❗ Current head 2b8329b differs from pull request most recent head 4079092. Consider uploading reports for the commit 4079092 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         5246      5252    +6     
=========================================
+ Hits          5246      5252    +6
Files Coverage Δ
starlette_admin/contrib/sqla/view.py 100.00% <100.00%> (ø)
tests/sqla/test_sync_engine.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request October 28, 2023 04:11 Inactive
@jowilf jowilf merged commit ccdf8b5 into main Oct 28, 2023
6 checks passed
@github-actions github-actions bot temporarily deployed to pull request October 28, 2023 04:13 Inactive
@jowilf jowilf mentioned this pull request Oct 28, 2023
Closed
@jowilf jowilf deleted the fix-347 branch October 28, 2023 04:43
jowilf added a commit that referenced this pull request Nov 6, 2023
@hasansezertasan @pre-commit-ci @jowilf
Fixed a regression caused by #361 where SQLAlchemy models with Mixin …
9646fbe 
…Classes raises AttributeError (#385)

* Solve 383

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Altered test_sqla_and_pydantic.py to use mixins for ID columns.

* Ignore mypy Errors.

* Implement the easiest fix, avoiding the need to inspect the model twice.

* Add changelog

* Add changelog

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jocelin Hounon <hounonj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Primary key column not recognised by Starlette-admin
1 participant
@jowilf