SSL Connection Error / Issues with PR 12

[shofetim]

Hello,

Prior to #12 this code worked:

(import http)
(pp (http/get "https://example.com"))

Post PR #12 it instead errors with "SSL Connection Error"

I believe that this (from #12)

Janet janet_port = janet_table_get(options, janet_ckeywordv("port"));
  long port = 80;

  if (janet_checktype(janet_port, JANET_NUMBER)) {
    port = (long)janet_unwrap_integer(janet_port);
  }

was intended to supply a default port (80) if no port was specified, which it does, but in so doing it makes port a required option for all non-http requests.

Prior to #12 we could already specify a port, like so:

(import http)
(pp (http/get "http://localhost:8080"))

Which to me feels like the more natural place to do so.

Could we return to curl determining the default port if not specified?

[swlkr]

Oh my gosh, I didn't even realize this, yeah I'll roll it back

[swlkr]

Closed by 9c93d46