Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify http request port #12

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Khachig
Copy link
Contributor

@Khachig Khachig commented Aug 1, 2023

Added a few lines to check for the "port" keyword in the argv struct and set the request port accordingly in curl opts.

@swlkr
Copy link
Contributor

swlkr commented Aug 2, 2023

LGTM! I'm assuming the cast to long is a libcurl thing

@swlkr swlkr merged commit ec37b13 into joy-framework:master Aug 2, 2023
@Khachig
Copy link
Contributor Author

Khachig commented Aug 2, 2023

LGTM! I'm assuming the cast to long is a libcurl thing

Yeah it's from curl docs.

shofetim pushed a commit to shofetim/http that referenced this pull request Aug 31, 2023
This reverts commit ec37b13, reversing
changes made to e378782.
swlkr added a commit that referenced this pull request Sep 11, 2023
This reverts commit ec37b13, reversing
changes made to e378782.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants