This repository has been archived by the owner on May 4, 2018. It is now read-only.
unix: fix running loop when all handles are unref'd #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the lighning fast review @bnoordhuis ;-) I just force pushed with the suggested changes. |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This pull request contains 2 fixes: the first commit disallows NULL to be passed as a callback to prepare/idle/check handles and modifies the tests accordingly.
After the first commit, the build fails on unix (test-ref) because the event loop will run once even if all handles are unref'd. This wasn's apparent because the tests in test-ref used NULL as a callback. The second commit fixes this.
/cc @bnoordhuis @piscisaureus