unix: fix running loop when all handles are unref'd #666

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

saghul commented Dec 24, 2012

Hi!

This pull request contains 2 fixes: the first commit disallows NULL to be passed as a callback to prepare/idle/check handles and modifies the tests accordingly.

After the first commit, the build fails on unix (test-ref) because the event loop will run once even if all handles are unref'd. This wasn's apparent because the tests in test-ref used NULL as a callback. The second commit fixes this.

/cc @bnoordhuis @piscisaureus

Contributor

saghul commented Dec 24, 2012

Thanks for the lighning fast review @bnoordhuis ;-) I just force pushed with the suggested changes.

Contributor

bnoordhuis commented Dec 24, 2012

Thanks Saúl, landed in 33d5c49 and 4650a59.

bnoordhuis closed this Dec 24, 2012

Contributor

saghul commented Dec 24, 2012

Awesome, thanks!

saghul deleted the unknown repository branch Sep 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment