This repository has been archived by the owner on May 4, 2018. It is now read-only.
Read console fixes #877
Open
Read console fixes #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit MSOpenTech/libuv@e2607ec2407797b4f87fbc052a7a3dda7ceb4411 has the following error(s):
Commit MSOpenTech/libuv@363373dba61736e59211792584e8dda6687b7e0b has the following error(s):
Commit MSOpenTech/libuv@ec6411a3996087e305d15d6fc77be5ccfe9ed914 has the following error(s):
Commit MSOpenTech/libuv@8100f22a94e0252f9934925426a40bbe3aab094d has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
…ty_press_key->uv_tty_simulate_enter_key_press, and style changes
…into ReadConsoleFixes Conflicts: src/win/tty.c uv.gyp
|
Is it still relevant? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked pull request #873. Sending a return key to force ReadConsoleA to exit before closing the stdin handle. Fix only applies only for Win8+.