x64 Windows installer installs to incorrect path #25087
Comments
|
I uninstalled my previous x86 nodejs installation. Now when I run the x64 installer it uses c:\program files. |
|
@joyent/node-coreteam Is it the desired behavior that an install of the 64 bits version when a 32 bits is already installed is considered as an upgrade, and thus the target directory is the same as the upgraded version ( |
|
Adding the confirmed-bug label, even though it's not clear it's a bug. |
|
It is unexpected behavior for a 64bit installer to place an application in C:\Program Files (x86). If a 64 bit version of node cannot coexist with a 32 bit version of node on the same machine, I think the correct action would be for the installer to ask the user if they wish to uninstall the existing node installation prior to installing the 64 bit version. Otherwise, I think that installing the 64 bit version to C:\Program Files\ (and upgrading any existing 64 bit install) would be the expected behavior. |
|
@sbmelvin That sounds reasonable to me, thank you 👍 @orangemocha I'm not familiar with how Windows users deploy node on Windows, any thoughts? |
Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixes #5592 Fixes #25087 PR-URL: #25640 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Bert Belder <bertbelder@gmail.com>
|
Fixed by 14db629, but this will only work on fresh installs starting from the next release. Thank you! |
|
👍 |
This is a port of 14db629. Original commit message: Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixes nodejs/node-v0.x-archive#5592 Fixes nodejs/node-v0.x-archive#25087 PR-URL: nodejs/node-v0.x-archive#25640 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Bert Belder <bertbelder@gmail.com> PR-URL: nodejs#2565 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
This is a port of 14db629. Original commit message: Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixes nodejs/node-v0.x-archive#5592 Fixes nodejs/node-v0.x-archive#25087 PR-URL: nodejs/node-v0.x-archive#25640 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Bert Belder <bertbelder@gmail.com> PR-URL: nodejs#2565 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
This is a port of 14db629. Original commit message: Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixes nodejs/node-v0.x-archive#5592 Fixes nodejs/node-v0.x-archive#25087 PR-URL: nodejs/node-v0.x-archive#25640 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Bert Belder <bertbelder@gmail.com> PR-URL: #2565 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Cherry picked to v3.x by @rvagg, PR: #2608
Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixes nodejs#5592 Fixes nodejs#25087 PR-URL: nodejs#25640 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Bert Belder <bertbelder@gmail.com>
I just downloaded the x64 Windows installation MSI and it wants to install to C:\Program Files (x86)\nodejs instead of C:\Program Files\nodejs
Is this correct? I thought the default path for 64-bit installers was C:\Program Files\ ?
The text was updated successfully, but these errors were encountered: