Object inherited from http.ClientRequest won't emit 'finish'

[biril]

var req = http.request("http://example.com", function () {});
req.on("finish", function () {
    console.log("finish");
});
req.end();

Will log "finish" but

var req = http.request("http://example.com", function () {});
req = Object.create(req);
req.on("finish", function () { // Never emitted
    console.log("finish"); 
});
req.end();

Will log nothing. Which I think is due to this check failing (taken from 10.12). Isn't this problematic?

[OrangeDog]

Why are you trying to do this? You probably want to either use a composition or a pipeline model, rather than inheritance.

[biril]

No disagreement there, I could go about doing this differently.

However, I only managed to get an indication that I should do it differently by stepping through http.js. If there is some other indication that I shouldn't be doing this please do point me to it. Otherwise, the fact of the matter is that inheriting ClientRequest will break functionality in an unforeseen way. (It actually gave me quite a bit of grief when upgrading from 0.8). And it is in that sense that I view it as potentially problematic.

[chrisdickinson]

I can't reproduce this behavior on v0.11 or v0.10. The code given seems to hang due to response not being resumed, not due to the Object.create.

[biril]

I still get the same behaviour on v0.10.21. First version will log 'finish', second version which includes req = Object.create(req); will not.

[indutny]

v0.10.21 is very very outdated, please check out nodejs.org website for the latest version.