Reduced the number of channels between service and process #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippPlank
approved these changes
Dec 20, 2021
| @@ -129,7 +128,6 @@ def test_get_set_var_using_var_api(self): | |||
| process.run(condition=RunSteps(num_steps=5), run_cfg=run_config) | |||
| assert np.array_equal(process.u.get(), expected_result_u) | |||
| assert np.array_equal(process.v.get(), expected_result_v) | |||
| self.assertEqual(process.runtime.global_time, 15) | |||
There was a problem hiding this comment.
Same as above, compare with the time step in ProcModel
| @@ -59,7 +59,6 @@ def test_synchronization_single_process_model(self): | |||
| run_config = SimpleRunConfig(sync_domains=[simple_sync_domain]) | |||
| process.run(condition=RunSteps(num_steps=10), run_cfg=run_config) | |||
| process.run(condition=RunSteps(num_steps=5), run_cfg=run_config) | |||
| self.assertEqual(process.runtime.global_time, 15) | |||
| exe: Executable, | ||
| message_infrastructure_type: ActorType): | ||
| self._run_cond: AbstractRunCondition = run_cond | ||
| self._run_cond: typing.Optional[AbstractRunCondition] = None |
There was a problem hiding this comment.
Why is the RunCondition optional? This internal RunCondition is and was not used by the Runtime, as far as I can see. I think we do not need it, correct?
joyeshmishra
approved these changes
Dec 21, 2021
ysingh7
added a commit
that referenced
this pull request
Jan 13, 2022
…-nc#157) * Reduced the number of channels between service and process (#1) * Reduced the number of channels between service and process * Fixed the bug with failing monitor cases * Reduce the number of channels to communicate between runtime and runtime_service * Fix flake8 related issues * Fix flake8 related issues Co-authored-by: Joyesh Mishra <joyesh.mishra@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: Remove hacks and refactor Runtime and RuntimeService/Synchronizer lava-nc#86
Objective of pull request: Reduced the number of channels between service and process
Pull request checklist
Your PR fulfills the following requirements:
pyb) passes locallypyb -E unit) or (python -m unittest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information