Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the number of channels between service and process (#1) #157

Merged
merged 4 commits into from Jan 6, 2022

Conversation

ysingh7
Copy link
Contributor

@ysingh7 ysingh7 commented Jan 5, 2022

  • Reduced the number of channels between service and process

  • Fixed the bug with failing monitor cases

Issue Number: Remove hacks and refactor Runtime and RuntimeService/Synchronizer #86

Objective of pull request: Reduced the number of channels between service and process

Pull request checklist

Your PR fulfills the following requirements:

  • [X ] Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • [X ] PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • [X ] Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Currently we have five channels between runtime service and process model.
    1. Used for sending cmd from RS to PM
    1. Used for sending ack back from PM to RS
    1. Used for sending READ/WRITE Req from RS to PM
    1. Used to send write data from RS to PM
    1. Used to send read data from PM to RS

What is the new behavior?

  • Reduces the number of channels between runtime service and process model. Also it removes the notion of time step from the runtime.
    1. One way channel for all cmd/get-set-req/data from RS to PM
    1. One channel for all ack/data from PM to RS

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

* Reduced the number of channels between service and process

* Fixed the bug with failing monitor cases
@joyeshmishra joyeshmishra merged commit 62b2f07 into lava-nc:main Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants